3 ms·
I often add multiple comments and then approve the pr. My main question is always: does this make the codebase overall better or worse for some definition of go
by nielsole 3y ago
I often add multiple comments and then approve the pr. My main question is always: does this make the codebase overall better or worse for some definition of good? If that bar is met, iterative improvements should not block deployment/merge.
This way the value of the pr process is captured: preventing obviously bad changes from reaching prod and two-way knowledge sharing.
Setting a higher bar for reviews more often than not blocks people for days without good reason.
- bornfreddy 3y agoI always make sure that author can resolve my comments. If they can't do that, the pr is not approved - because I would like them to address something. If I approve it, then each of my comments should be resolvable.