3 ms·
Code reviews seem like a hellscape of "could do X". Like man it's code, there's an infinite amount of "could do" with an infinite amount of contexts. I found
by duxup 3y ago
Code reviews seem like a hellscape of "could do X".
Like man it's code, there's an infinite amount of "could do" with an infinite amount of contexts.
I found google's advice to be pretty good https://google.github.io/eng-practices/review/ https://google.github.io/eng-practices/review/ while they give a lot of good advice / suggestions, they also make a point that there aren't a lot of hard stops and generally if the code works and isn't horrendous you let it go.
- s__s 3y agoIf the code works let it go? That’s an incredibly low bar to set. Unless you’re working on an all-star team, that approach will quickly get your codebase in a really bad place with incredible amounts of technical debt.
- duxup 3y agoI think you have to read their process to be clear. They don't want to hold up things over style quibbles and etc. It is something they're ok with talking about, but not every aspect that could be improved is a hard stop.
- polishdude20 3y agoI feel like if you're looking for design feedback during the code review that's already way too late. There should be much more communication going on before the coding even happens.
- JKCalhoun 3y agoUsually no one is looking for design feedback, but plenty of offers....
- duxup 3y agoYeah. I think a nice little "Hey I saw this that doesn't match this design doc here, but this all looks good regardless." type reminder would be ok. Obviously being diplomatic / soft skills is huge and the google doc addresses that a great deal. But yeah especially if this is a non-trival change / lotta work ... not time to re-invent the wheel.
- ddejohn 3y agoFor anybody else curious (maybe this was just new to me), the abbreviation CL (used all over the place in the linked docs but never actually defined anywhere I could find) stands for change log, or change list, near as I can tell. Am I the only one out of the loop here?