3 ms·
If the code review process is (through your supportive wisdom) pushing the people you work with to follow those practices, then I would argue it is actually a p
by sanderjd 3y ago
If the code review process is (through your supportive wisdom) pushing the people you work with to follow those practices, then I would argue it is actually a pretty good process. Those are all very good things to do, that a good code review culture should definitely be pushing people toward.
For instance, let's imagine this without the code review process and your subsequent advice on how to make it go better: People would just be merging in the 20 file PRs, sight unseen, without validating a strategy beforehand, without really knowing how to approach the problem, with the code just written and slapped together without tweaking and refactoring, and without any self-review using a critical eye to catch low-hanging fruit like leaving in console.logs calls. I think the "flawed" code review process seems like a much better outcome!
- schwartzworld 3y agoThe problem is that reviewing is itself a skill, and many people are bad at it.