3 ms·
I agree that this post outlines a miserable code review, but where I work I often see the opposite: a miserable submission. Is it wrong to expect engineers new
by thegrimmest 3y ago
I agree that this post outlines a miserable code review, but where I work I often see the opposite: a miserable submission. Is it wrong to expect engineers new to the project spending a few whole days (read 8-24 full hours) just reading the documentation, code, tests, project layout, etc.? This time would be invaluable to avoid reimplementing things that already exist, following existing patterns and styles, understanding where to put things, etc.
Why do people expect to come on to a multi-100k-line project and just slap out a complex feature in a few days? Of course they'll end up with many dozens of comments from senior maintainers and everyone (including POs) will be very frustrated. It's pretty easy to avoid though by just following a sane ramp-up.