3 ms·
Reviewers are responsible for not just pointing out issues, but also providing (at a minimum) some form of direction, or (more ideally) one or more explicit sug
by kiitos 3y ago
Reviewers are responsible for not just pointing out issues, but also providing (at a minimum) some form of direction, or (more ideally) one or more explicit suggestions as to how to resolve those issues.
This is an essential component of a productive code review culture.
- bobthepanda 3y agoYeah, a good review must explain why, and should ideally explain how it should be instead if it needs explaining. * This code should be changed looks bad - not a good comment * This code should be chabged because ten nested ternaries gets hard to read - better * This code is hard to read because there are ten nested ternaries. Can we replace it with a helper method that returns one value using if blocks? - best, in terms of actionability