4 ms·

Totally agree it's flawed, but very often the reason it's flawed is because something has gone wrong somewhere else. Yes, it's very common for someone to do a P

Totally agree it's flawed, but very often the reason it's flawed is because something has gone wrong somewhere else. Yes, it's very common for someone to do a PR and for someone else to turn around and go "Oh god, why the hell did you do it like this?!" - Fundamentally challenging the entire purpose of the code. What's happening there is the code review is just highlighting the fact you didn't have a design review. You also have to have a shared understanding of what's a reasonable request in a review, I've been in teams that relentlessly nitpick and teams that just "LGTM"s, eithers fine as long as you're agreed and consistent on what your team wants to do.

datavirtue 3y ago
[flagged]
- digging 3y ago
  Honestly, you sound like an asshole here. Do you realize that Adderall is a medication? Do you realize how fucked up it is to call someone mentally defective as if your brain meet some standard of perfect functioning? (it doesn't.)
  - datavirtue 3y ago
    No one cares after they tumble over the edge and make everyone miserable. It ain't helping anymore.
- thegrimmest 3y ago
  I dunno mate, I think adults should be able to handle being chortled at. You're responsible for your own emotional state. If you've done something laughable (or even if you haven't), then don't be surprised when people laugh. Taking it personally is optional and not recommended.
  - atq2119 3y ago
    I agree that people shouldn't be too thin-skinned, it's still important to stay civil and supportive. Being able to clearly and unambiguously convey that a change sucks while not hurting the other person's feeling is a useful skill to practice. (It's okay to fail at it, too, as long as you're aware that that's almost always a weakness.)
    - thegrimmest 3y ago
      The issue is the broad, ambiguous, definitions of things like "civil". In many cultures (eg. French, Russian) a direct, no-nonsense communication style is the default. You can just say things like "Your idea is hilariously stupid" and no one really gets bent about it. In the world of multicultural, international business, this seems like the most viable default, simply because it's the easiest to codify and communicate. Trying to teach very culturally-specific minutia of civility to a diverse staff just gets in the way. I'd rather work somewhere the burden of not being offended is placed on the listener, not the speaker. Somewhere we can just say what we think.

datavirtue 3y ago

[flagged]

digging 3y ago
Honestly, you sound like an asshole here. Do you realize that Adderall is a medication? Do you realize how fucked up it is to call someone mentally defective as if your brain meet some standard of perfect functioning? (it doesn't.)
- datavirtue 3y ago
  No one cares after they tumble over the edge and make everyone miserable. It ain't helping anymore.
thegrimmest 3y ago
I dunno mate, I think adults should be able to handle being chortled at. You're responsible for your own emotional state. If you've done something laughable (or even if you haven't), then don't be surprised when people laugh. Taking it personally is optional and not recommended.
- atq2119 3y ago
  I agree that people shouldn't be too thin-skinned, it's still important to stay civil and supportive. Being able to clearly and unambiguously convey that a change sucks while not hurting the other person's feeling is a useful skill to practice. (It's okay to fail at it, too, as long as you're aware that that's almost always a weakness.)
  - thegrimmest 3y ago
    The issue is the broad, ambiguous, definitions of things like "civil". In many cultures (eg. French, Russian) a direct, no-nonsense communication style is the default. You can just say things like "Your idea is hilariously stupid" and no one really gets bent about it. In the world of multicultural, international business, this seems like the most viable default, simply because it's the easiest to codify and communicate. Trying to teach very culturally-specific minutia of civility to a diverse staff just gets in the way. I'd rather work somewhere the burden of not being offended is placed on the listener, not the speaker. Somewhere we can just say what we think.