3 ms·
Minimum 5 days hurt. Too real. If there’s one way to destroy productivity and morale it’s to leave a vague comment on a review and not come back to it for a few
by agentultra 3y ago
Minimum 5 days hurt. Too real. If there’s one way to destroy productivity and morale it’s to leave a vague comment on a review and not come back to it for a few days.
- cjfd 3y ago5 days is very quick. I have an open pull request that has been open for 6 months or thereabouts.... :-( No, I am not suggesting this as a good practice.... Actually, I would say that a pull request should be reviewed in 24 hours. Pull requests made on Friday may wait until Monday.
- withinboredom 3y agoI have an open PR from my first week. Not a single review. I’ve merged entire features since then…
- polishdude20 3y agoDo you specifically ping people to review? At my company we've got a habit of not only assigning reviewers in GitHub but also pinging them in slack.
- withinboredom 3y agoIt’s a dev environment improvement so I pinged the whole team. Nothing like a chilly start at a new company eh?