4 ms·
What, those are rookie numbers! I opened a pull request 13 business days ago. I even rebased it multiple times when conflicting code was otherwise merged. There
by fuzzy2 3y ago
What, those are rookie numbers! I opened a pull request 13 business days ago. I even rebased it multiple times when conflicting code was otherwise merged. There’s been no feedback whatsoever. Everyone even remotely involved is now on vacation.
(It’s not like I care either, the project sucks anyway.)
- kxrm 3y agoThe best is when the only possible reviewer is your Engineering Manager because you have no other engineers in your domain on the team.
- Maxion 3y agoThe best is when you are the technical lead with admin rights, but there's no one on the team senior enough to actually want to review your code. You leave itfor two weeks when the person who should be PO, but is never in any meetings, doesn't look at the tickets or the pull requests, and only reachable by email calls you asking where the feature is.
- hobs 3y agoThat's lucky to have a manager who even logs into GitHub. Many jobs of mine I have been my own approver.
- kxrm 3y agoI think it is a huge assumption to believe my Engineering Manager even has time to review anything within the next 2 weeks. Every time I have hit this at my company I have had a minimum wait of almost 3 weeks on average. However, yea, against just approving your own code, this is better.