4 ms·
Why does the flag use different representation depending on whether the value is negative?
by nikic 3y ago
Why does the flag use different representation depending on whether the value is negative?
- PaulDavisThe1st 3y agoI will try to remember. Vague recollection was that it was necessary to get something obvious to work.
- aydyn 3y agoyoure making a real good case for better documenting one’s code right now
- tomcam 3y agoDo you think Paul doesn’t want to comment his code perfectly? Is it your thought that he has unlimited time to create complex free software up to your coding standards? You’re making a really good case for flagging comments, which I almost never do.
- PaulDavisThe1st 3y agoThanks for the defense, but to be honest I think GP has a point. Why on earth I would have used 2's complement conventions for what is truly just a boolean/bistate flag is far from obvious, and it ought to be (better) commented. One thing I would say in my own defense is that one aspect of remote-distributed cooperative development is that sometimes the conversations you have with others (e.g. on IRC, or mattermost or even discord if that's your thing) can sometimes feel as if you've just "written the documentation", even though it will generally vanish into the ether. I think that is what happened here. I remember discussing it with others on our IRC dev channel, but I don't keep logs.
- tomcam 3y agoYou’re a champ and I love you for that, but it’s no excuse for that kind of rudeness. There is literally no easier nor shallower critique in programming than one should’ve commented a little better. You rock, literally!
- aydyn 3y agomate, you need to relax fr. Its just a friendly jib
- tomcam 3y agoOops. Now I feel bad—my apologies.
- heavenlyblue 3y agoNo matter how free code is, if it can't prove to me what it does and it's design decision, it may as well not exist at all.