3 ms·
Please forgive me with your mighty experience, I'm young, naive, and impatient, new to the open source, and the software industry, I received a lot of criticism
by Dhikshith12 3y ago
Please forgive me with your mighty experience, I'm young, naive, and impatient, new to the open source, and the software industry, I received a lot of criticism for this article, and I'll learn to do better and be more patient.
But if you read the article, i even begun to write the article only because i found a PR that was left unnoticed, uncommented, even by their CI system (Expected — Waiting for status to be reported) for almost a year.
It's not cool to get ghosted for a year!
Thank you : |
- seba_dos1 3y ago> It's not cool to get ghosted for a year! And yet it's perfectly normal.
- twiss 3y agoI did read your article and did look at the other PR, but to be perfectly honest it looked a bit low-effort; the justification is simply "It just makes more sense that way", and the change looks very minor. (Which, of course I don't blame the PR author because they're not obligated to do anything, but at the same time I can't blame the maintainers as much for not merging it.) Your PR, on the other hand, looks great! The changes look well-reasoned and well-documented, though I don't know Calculator so I can't judge the code. But, don't be discouraged, neither by the lack of response so far, nor the criticism here. Hopefully they'll merge your PR, if not, I hope you'll find some other open source project you can contribute to, or you can start your own :) (I should've also said the positive part in my first comment, not just the negative part, apologies.)