5 ms·

> This design removes the need for any sort of server-side setup. So what, I just write code reviews to myself? What happens when I want to review other people

by rcme 3y ago

> This design removes the need for any sort of server-side setup. So what, I just write code reviews to myself? What happens when I want to review other peoples’ code? Where do I get it from? And when they want to read my comments, do I invite them over to my computer?

matt-robertson 3y ago
I believe their docs cover the scenario of reviewing someone's code by pushing your review to the git repo, and others can use `git appraise list` to see open pull requests. https://github.com/google/git-appraise/blob/master/docs/tutorial.md#sending-our-updates-to-the-remote-repository https://github.com/google/git-appraise/blob/master/docs/tuto... A trivial git-hook could be setup for automating email notifications: https://git-scm.com/book/en/v2/Customizing-Git-Git-Hooks https://git-scm.com/book/en/v2/Customizing-Git-Git-Hooks EDIT: add link to git-hooks docs.
- rcme 3y ago
  > I believe their docs cover the scenario of reviewing someone's code by pushing your review to the git repo, and others can use `git appraise list` to see open pull requests. How do they push without a server to host the repository?
  - matt-robertson 3y ago
    Git uses a decentralized model where clients/servers are blurred and really only matter if you choose to create a "central" node of git as part of your workflow but you do not have to. More importantly, the significance to me is that it does not require any software other than git, which means I can use this approach independent of any git-hosting service. Especially moving between git-hosting services, it would be nice to have a standard way to operate pull requests.
  - pgeorgi 3y ago
    They push to their own server and ask you to pull from there. See https://lkml.org/lkml/2023/6/25/128 https://lkml.org/lkml/2023/6/25/128 for an example.
predictabl3 3y ago
It's in the first three paragraphs of the README... > By "distributed", we mean that code reviews are stored inside of the repository as git objects. Every developer on your team has their own copy of the review history that they can push or pull. Before the part you quoted. I feel like it'd be "nice" of me to suggest maybe you're being pedantic. Otherwise... ?
- rcme 3y ago
  [flagged]
  - taberiand 3y ago
    You don't strictly need a central server, you just need an upstream path between the people involved in the PR. Eg if two developers both served up the same repo from their local machine, and each had an upstream to the other, then this would work as a distributed PR. And you could have any number of arbitrary nodes in that graph
    - deleted 3y ago
      [deleted]
    - rcme 3y ago
      No, that's not decentralized. If two people agree to use a "local" machine, then that local machine is a centralized server. If User A and B use User A's local machine, then User C has no choice but to use User A's local machine to participate in their code review. That's centralized.
      - taberiand 3y ago
        You misunderstand me. In the example I gave, both developers serve the repository. Both developers connect to the other. It's peer to peer. A -- origin --> B A <-- origin -- B
        3y ago

by rcme 3y ago

matt-robertson 3y ago

I believe their docs cover the scenario of reviewing someone's code by pushing your review to the git repo, and others can use `git appraise list` to see open pull requests. https://github.com/google/git-appraise/blob/master/docs/tutorial.md#sending-our-updates-to-the-remote-repository https://github.com/google/git-appraise/blob/master/docs/tuto... A trivial git-hook could be setup for automating email notifications: https://git-scm.com/book/en/v2/Customizing-Git-Git-Hooks https://git-scm.com/book/en/v2/Customizing-Git-Git-Hooks EDIT: add link to git-hooks docs.

rcme 3y ago
> I believe their docs cover the scenario of reviewing someone's code by pushing your review to the git repo, and others can use `git appraise list` to see open pull requests. How do they push without a server to host the repository?
- matt-robertson 3y ago
  Git uses a decentralized model where clients/servers are blurred and really only matter if you choose to create a "central" node of git as part of your workflow but you do not have to. More importantly, the significance to me is that it does not require any software other than git, which means I can use this approach independent of any git-hosting service. Especially moving between git-hosting services, it would be nice to have a standard way to operate pull requests.
- pgeorgi 3y ago
  They push to their own server and ask you to pull from there. See https://lkml.org/lkml/2023/6/25/128 https://lkml.org/lkml/2023/6/25/128 for an example.

predictabl3 3y ago

It's in the first three paragraphs of the README... > By "distributed", we mean that code reviews are stored inside of the repository as git objects. Every developer on your team has their own copy of the review history that they can push or pull. Before the part you quoted. I feel like it'd be "nice" of me to suggest maybe you're being pedantic. Otherwise... ?

rcme 3y ago
[flagged]
- taberiand 3y ago
  You don't strictly need a central server, you just need an upstream path between the people involved in the PR. Eg if two developers both served up the same repo from their local machine, and each had an upstream to the other, then this would work as a distributed PR. And you could have any number of arbitrary nodes in that graph
  - deleted 3y ago
    [deleted]
  - rcme 3y ago
    No, that's not decentralized. If two people agree to use a "local" machine, then that local machine is a centralized server. If User A and B use User A's local machine, then User C has no choice but to use User A's local machine to participate in their code review. That's centralized.
    - taberiand 3y ago
      You misunderstand me. In the example I gave, both developers serve the repository. Both developers connect to the other. It's peer to peer. A -- origin --> B A <-- origin -- B
      - 3y ago