3 ms·
Honestly, I don’t think code reviews make a ton of sense. If the things wrong with the code are so deep as to warrant a “teaching moment” then whatever help I t
by baerrie 3y ago
Honestly, I don’t think code reviews make a ton of sense. If the things wrong with the code are so deep as to warrant a “teaching moment” then whatever help I try to give is probably so fundamental that it is unlikely to find purchase. I think we would be better off encouraging consistent and quick refactoring rather than diligent review. For example, a dev puts up a pr, things are technically fine but there are a lot of architectural issues, rather than waste time trying to teach them to make the changes, I would refactor them as part of another story, showing the “correct” way if they care and ensuring the code base is better off even if they don’t. Not to mention code reviews slow down dev and qe soooo much