4 ms·
We have lots of config in git, which requires code reviews. 90% of PRs are trivial changes. its especially annoying if you're working on your own. Also as a se
by rr808 3y ago
We have lots of config in git, which requires code reviews. 90% of PRs are trivial changes. its especially annoying if you're working on your own.
Also as a senior I often have to get managers or green newbies to approve, neither which can add any useful feedback.
- Attummm 3y agoFrom the description, it appears the issue is more organizational than related to code reviews. Similar to how 'security theater' addresses perceived threats rather than real vulnerabilities. It takes two parties atleast for productive code review
- whstl 3y agoFor those cases I just bypass approval. You should try asking for this permission. If you can’t get it, then you have a problem.