4 ms·
> Be kind > This is self-explanatory. Usually I start off a review to someone who I don’t know yet with a simple “Hi ” in the first comment. If you spot someth
by Tade0 3y ago
> Be kind
> This is self-explanatory. Usually I start off a review to someone who I don’t know yet with a simple “Hi ” in the first comment. If you spot something missing, don’t express this with a statement such as, “This is incomplete”, but rather, ask: “Is there a reason why this is missing?”
I chalk this up to cultural differences, but to me questions like this appear from avoidant to interrogatory. Questions are good when you genuinely don't know something and are asking for help in reviewing.
Anyway, I got a lot of mileage out of the phrase "you can...", e.g.
You can use <language feature> here like this: [...]
You can get the same result with this: [...] (typically an idiomatic one-liner)
etc.
I find people are more receptive to suggestions if they're given a choice in the matter. They better explain it though - which is also what usually happens.
If there's an issue I write something among the lines of "To prevent X errors, use Y." to make it obvious that this isn't just my taste.
The Suggested Change feature is very useful and usually doesn't require additional commentary - especially for one liners.
Also: nothing beats a call review, especially if you don't know the person.
> Attention to detail
> Try to balance between important and not-so-important changes (experience will guide you). We don’t want to block an important feature or production bug because of a spacing issue!
Create a ticket if it's warranted, assign priority and move on.