3 ms·

I sometimes wonder how many thousands of people have quit / been fired because of Github code reviews. I'm not saying they're bad idea, but Github's is too raw

by vemv 3y ago

I sometimes wonder how many thousands of people have quit / been fired because of Github code reviews. I'm not saying they're bad idea, but Github's is too raw of an implementation that makes it too easy to create conflict. Only after being burned by them a few dozen times, one can learn to use them in an effective and (mostly) drama-free manner. Some practical improvements I'd like to see: - invite/enforce reviewers to review their own batch of comments. Are they correct, relevant, kind? - integrate AI for sentiment analysis. Could you say the same thing in a more constructive way? Are you supporting your claims factually with a snippet of code or link?

computerfriend 3y ago
I dislike GitHub's UI as much as the next person, but I think it's a bit of a stretch to blame them for the content of a code review.
- XorNot 3y ago
  Github's UI (and Gitlab and every other system - they all suck) makes a lot of aspects of code-reviews needlessly difficult. For example, you can submit PRs to non-main branches. Which means you can submit PRs to PR branches. Which should mean that a code-review asking for changes can just...be the changes. This would work fine, but there's no UI for it in Github, so doing it is useless - no one wants to understand it. And then if we had this capability, then realistically, shouldn't the comment UI work the same way? I can already checkout a PR as a branch, so why can't I just inline edit those files with comments and have them upload as comments directly? This would be much more effective since viewing the whole context of a change, rather then whatever git patch decides is the context, is usually necessary to properly appreciate a change. Again: the functionality doesn't exist (and it's not technically difficult to implement) - but because of that, far too many reviews are just of whatever the change displays as in the UI. Instead we have this miserable land of self-flagellation - "could you change X to Y?" - style comments, where the original author is needlessly put through extra actions to implement the change, re-push the branch etc. All things which have nothing to do with whether the request is a good idea.
- codeapprove 3y ago
  Shameless plug but if you dislike GitHub's code review UI you could try my product, CodeApprove (https://codeapprove.com https://codeapprove.com). There are actually dozens of great code review tools out there: https://medium.com/codeapprove/the-best-modern-code-review-tools-2022-468b51751fa https://medium.com/codeapprove/the-best-modern-code-review-t... Im my opinion very few professional dev teams should settle for GitHub's default UI!
hardware2win 3y ago
Having github at work is one of the best things that happened to me.

by vemv 3y ago

computerfriend 3y ago

I dislike GitHub's UI as much as the next person, but I think it's a bit of a stretch to blame them for the content of a code review.

XorNot 3y ago
Github's UI (and Gitlab and every other system - they all suck) makes a lot of aspects of code-reviews needlessly difficult. For example, you can submit PRs to non-main branches. Which means you can submit PRs to PR branches. Which should mean that a code-review asking for changes can just...be the changes. This would work fine, but there's no UI for it in Github, so doing it is useless - no one wants to understand it. And then if we had this capability, then realistically, shouldn't the comment UI work the same way? I can already checkout a PR as a branch, so why can't I just inline edit those files with comments and have them upload as comments directly? This would be much more effective since viewing the whole context of a change, rather then whatever git patch decides is the context, is usually necessary to properly appreciate a change. Again: the functionality doesn't exist (and it's not technically difficult to implement) - but because of that, far too many reviews are just of whatever the change displays as in the UI. Instead we have this miserable land of self-flagellation - "could you change X to Y?" - style comments, where the original author is needlessly put through extra actions to implement the change, re-push the branch etc. All things which have nothing to do with whether the request is a good idea.
codeapprove 3y ago
Shameless plug but if you dislike GitHub's code review UI you could try my product, CodeApprove (https://codeapprove.com https://codeapprove.com). There are actually dozens of great code review tools out there: https://medium.com/codeapprove/the-best-modern-code-review-tools-2022-468b51751fa https://medium.com/codeapprove/the-best-modern-code-review-t... Im my opinion very few professional dev teams should settle for GitHub's default UI!

hardware2win 3y ago

Having github at work is one of the best things that happened to me.