3 ms·
bookmarked. sometimes code review becomes somewhat adversarial between teammates. but it should be critical and to the point! everyone has opinions
by acosmism 3y ago
bookmarked. sometimes code review becomes somewhat adversarial between teammates. but it should be critical and to the point! everyone has opinions
- whstl 3y agoI've been on the receiving end of some of those and honestly I prefer that to people not taking time to review your code because they don't have time, or because it ended up being too complex. Also worse than having zero comments. I'm pretty sure some of mine were also perceived as adversarial, especially when I had to ask for a re-do.
- ZaoLahma 3y agoAnd oftentimes hostile reviewing methods spread and become "best practice" in affected teams. Being polite and collaborative when reviewing always renders better results than all alternative approaches.