3 ms·

Sounds like they’d love your contribution. I hate when people prescribe tasks to others like this.

by Operyl 3y ago

kiwicopple 3y ago
yes, we (and I assume the pganalyze team) would always appreciate contributions fwiw, we know of this limitation and decided the acceptable workaround for Windows devs is simply to host the language server and they can connect to it via TCP.
- spapas82 3y ago
  Can't you just give some love to the issue https://github.com/pganalyze/libpg_query/issues/44 https://github.com/pganalyze/libpg_query/issues/44 instead ? As I said before this would be very helpful for the community because there are a lot of libraries that use libpg_query and cannot be used on windows (f.e see https://github.com/lelit/pglast/issues/7 https://github.com/lelit/pglast/issues/7). It seems that the only problem for fixing the problem is: > Thanks for the offer, but the problem is our team being time limited / having an engineer with a Windows machine ready to take this on, not that we wouldn't want to pay someone to work on it :) (https://github.com/pganalyze/libpg_query/issues/44#issuecomment-1309061509 https://github.com/pganalyze/libpg_query/issues/44#issuecomm...) Hosting the LSP elsewhere is not really needed since if people wanted to go that way they could use Remote ssh (https://code.visualstudio.com/docs/remote/ssh https://code.visualstudio.com/docs/remote/ssh) to host the whole dev environment on linux and connect to it. Thank you
  - macintux 3y ago
    After 5 years of spinning wheels, maybe it’s time to accept that Windows is a second-class citizen. That’s why WSL exists, after all. (Speaking as someone who dreaded the “inevitable” victory of Windows on the desktop in the 90s I might be a little biased/overjoyed.)
  - kiwicopple 3y ago
    cool, we’ll look into helping at an appropriate time. Since we are still developing the LSP, this issue isn’t affecting anyone > the only problem for fixing the problem is Hopefully it’s as easy as you make it sound!
  - bavell 3y ago
    Just use a serious development OS instead ;)
  - lfittl 3y ago
    We at pganalyze would definitely welcome help here - and if anyone would like to give this a try - feel free to email me, happy to talk this through, email is in my profile. Postgres itself supports Windows, the main challenge is identifying the relevant files to pull in (since we use a subset of the full source code), and testing the changes. It should be fairly quick for someone who has C development experience on Windows, with a working development environment.

Sounds like they’d love your contribution. I hate when people prescribe tasks to others like this.

by Operyl 3y ago

Sounds like they’d love your contribution. I hate when people prescribe tasks to others like this.

yes, we (and I assume the pganalyze team) would always appreciate contributions fwiw, we know of this limitation and decided the acceptable workaround for Windows devs is simply to host the language server and they can connect to it via TCP.

spapas82 3y ago
Can't you just give some love to the issue https://github.com/pganalyze/libpg_query/issues/44 https://github.com/pganalyze/libpg_query/issues/44 instead ? As I said before this would be very helpful for the community because there are a lot of libraries that use libpg_query and cannot be used on windows (f.e see https://github.com/lelit/pglast/issues/7 https://github.com/lelit/pglast/issues/7). It seems that the only problem for fixing the problem is: > Thanks for the offer, but the problem is our team being time limited / having an engineer with a Windows machine ready to take this on, not that we wouldn't want to pay someone to work on it :) (https://github.com/pganalyze/libpg_query/issues/44#issuecomment-1309061509 https://github.com/pganalyze/libpg_query/issues/44#issuecomm...) Hosting the LSP elsewhere is not really needed since if people wanted to go that way they could use Remote ssh (https://code.visualstudio.com/docs/remote/ssh https://code.visualstudio.com/docs/remote/ssh) to host the whole dev environment on linux and connect to it. Thank you
- macintux 3y ago
  After 5 years of spinning wheels, maybe it’s time to accept that Windows is a second-class citizen. That’s why WSL exists, after all. (Speaking as someone who dreaded the “inevitable” victory of Windows on the desktop in the 90s I might be a little biased/overjoyed.)
- kiwicopple 3y ago
  cool, we’ll look into helping at an appropriate time. Since we are still developing the LSP, this issue isn’t affecting anyone > the only problem for fixing the problem is Hopefully it’s as easy as you make it sound!
- bavell 3y ago
  Just use a serious development OS instead ;)
- lfittl 3y ago
  We at pganalyze would definitely welcome help here - and if anyone would like to give this a try - feel free to email me, happy to talk this through, email is in my profile. Postgres itself supports Windows, the main challenge is identifying the relevant files to pull in (since we use a subset of the full source code), and testing the changes. It should be fairly quick for someone who has C development experience on Windows, with a working development environment.