3 ms·
I perused the code and it was written in a C++03 style. Pointer chasing and manual memory management in the few files I poked through. (IE, no unique_ptr, just
by cogman10 3y ago
I perused the code and it was written in a C++03 style. Pointer chasing and manual memory management in the few files I poked through. (IE, no unique_ptr, just new/delete).
This may be perfectly safe... however, I'd give it a few years of battle testing before touching it.
Here's an example:
https://github.com/bloomberg/blazingmq/blob/main/src/groups/bmq/bmqimp/bmqimp_messagedumper.cpp https://github.com/bloomberg/blazingmq/blob/main/src/groups/...
- d4damager 3y agoI don’t see any examples of new/delete there? Also they do make heavy use of managed pointers in the codebase.
- MathMonkeyMan 3y agoLife is harder without move semantics, but allocators are easier.
- HWR_14 3y agoIsn't this opensourced after 8 years of being battletested in a very time/error sensitive environment (feeding bloomberg terminals)?
- cogman10 3y agoLol. I'm sorry but my work has me directly interfacing with Bloomberg and other financial institutions. If anything, I trust the code LESS because of who wrote it. Just because software is heavily used and deals with finance, doesn't mean it's secure or well written. Consider the Equifax breach of 2017, everyone's credit info leaked because Equifax was using a crusty old version of struts with known critical CVEs.
- HWR_14 3y agoI thought everyone's info leaked because an Equifax office in South America had open access to the internet with default passwords.