2 ms·
Good catch. I would prefer shadowing an unused built-in over using “inp”. Alternatively, “input_” should do fine.
by laserlight 3y ago
Good catch. I would prefer shadowing an unused built-in over using “inp”. Alternatively, “input_” should do fine.
- ilc 3y agoDon't shadow. Just don't. We've got enough variable names in the universe. :)
- laserlight 3y agoStrong agree. To clarify, I wouldn't shadow. I wouldn't use “inp” either.
- ali_m 3y agoOne fairly common convention is to suffix with `_` to avoid shadowing, e.g. `input_`
- EddieJLSH 3y agoPlease don't shadow ever :(
- mrelectric 3y agoMan..
- dacryn 3y agoshadowing is what instantly would have me reject a peer review. there is literally no excuse. inp is just standard in python, along with uin (user input), or sometimes also raw or iraw. You cannot win this battle. There is nothing wrong with 'inp'