3 ms·

Guessing: it is probably used in shell commands and there's no intent to handle escaping. Okay, guessing less: https://github.com/uyuni-project/uyuni/blob/88b6

Guessing: it is probably used in shell commands and there's no intent to handle escaping. Okay, guessing less: https://github.com/uyuni-project/uyuni/blob/88b6b3cf25a2fd6b4ffee455f051fc36660d5123/spacewalk/admin/spacewalk-startup-helper#L92 https://github.com/uyuni-project/uyuni/blob/88b6b3cf25a2fd6b.... By the way: 83k+ commits and 15k+ tags. There are seven programming languages in the main repository. Sounds impenetrable. PRs merged with failing tests and developers not following their own requirements, example: https://github.com/uyuni-project/uyuni/pull/7243#issuecomment-1624970243 https://github.com/uyuni-project/uyuni/pull/7243#issuecommen.... This commit is interesting: https://github.com/uyuni-project/uyuni/blame/df29070c58a9a1b739de9448e2a915d9e211bc24/susemanager-utils/susemanager-sls/modules/roster/uyuni.py#L93 https://github.com/uyuni-project/uyuni/blame/df29070c58a9a1b.... It fixes the password printed to logs which existed on the main branch for about a year.

mdaniel 3y ago
related to a recent discussion about Java exceptions (https://news.ycombinator.com/item?id=36708759 https://news.ycombinator.com/item?id=36708759), this project clearly haz all teh kwal-uh-teee: https://github.com/uyuni-project/uyuni/pull/7274/files#diff-661c57d20551d77896119f118519114a83043d3de4bc0adaf1da08a73ec22887R5722-R5723 https://github.com/uyuni-project/uyuni/pull/7274/files#diff-... catch (IOException e) { log.warn("Cannot read {}", file.getName()); } catch (IOException e) { log.warn("Cannot create " + NOREPO_FILE + " file."); } catch (IOException e) { return false; }
rjmateus 3y ago
Regarding that not following the developer rules, that specific commit was removing a module, which also removes the changes file for that module. The developer could not add a change log to a file there. The check is blind, so it returns the alert, but in this case can be ignored.

mdaniel 3y ago

related to a recent discussion about Java exceptions (https://news.ycombinator.com/item?id=36708759 https://news.ycombinator.com/item?id=36708759), this project clearly haz all teh kwal-uh-teee: https://github.com/uyuni-project/uyuni/pull/7274/files#diff-661c57d20551d77896119f118519114a83043d3de4bc0adaf1da08a73ec22887R5722-R5723 https://github.com/uyuni-project/uyuni/pull/7274/files#diff-... catch (IOException e) { log.warn("Cannot read {}", file.getName()); } catch (IOException e) { log.warn("Cannot create " + NOREPO_FILE + " file."); } catch (IOException e) { return false; }

rjmateus 3y ago

Regarding that not following the developer rules, that specific commit was removing a module, which also removes the changes file for that module. The developer could not add a change log to a file there. The check is blind, so it returns the alert, but in this case can be ignored.