4 ms·
If you want to someone to do lint, why not just run lint and save on an expensive hire? Code reviews are there to find problems with the code that are not foun
by wladimir 15y ago
If you want to someone to do lint, why not just run lint and save on an expensive hire?
Code reviews are there to find problems with the code that are not found by trivial static verifiers and/or IDEs. This requires a level of understanding of the language and experience in reading (instead of writing) code, but has nothing to do with regurgitating keyword definitions.
Better in that case to just give a code fragment and make them spot the (algorithmic, logic, security, not spelling) errors.
- gbvb 15y agoOk. I was making a point but I guess you are right about lint. I was trying to point out that it is easy have developers write code that can easily be O(n2) vs O(n log n) because this did not use the right kind of the maps when they were initially building the code. Or I can see developers using HashTables vs HashMaps interchangeably and not see the threading impact. In these cases, some basic questions about their understanding of the classes seem to be a good indicator. Would you consider that a nano-question? I was..