3 ms·
This week during code reviews, I caught: 1) O(N^2) in the hottest code we have. 2) O(N^3) from someone else in the same area. 3) Filling a cache on first acc
by jpollock 3y ago
This week during code reviews, I caught:
1) O(N^2) in the hottest code we have.
2) O(N^3) from someone else in the same area.
3) Filling a cache on first access - this causes the system to page (high latency!).
4) Hunting for data themselves and creating null pointer errors.
5) Hunting for data themselves and missing all the fun edge cases.
6) Duplicating a feature that already existed.
I'm guessing (4) could have been caught by static analysis?
- regularfry 3y agoPossibly (6), depending on the nature of the duplication.