3 ms·
This is exactly it. Most code reviewers make other people jump through hoops to force them to code 'their' way, whereas more often than not there are multiple w
by jacquesm 3y ago
This is exactly it. Most code reviewers make other people jump through hoops to force them to code 'their' way, whereas more often than not there are multiple ways to solve a problem neither of which is substantially better than the others. In the rare cases where there is a much better way of doing something there won't be anything to argue about, it will be obvious.
- gtirloni 3y agoI will often follow the codebase's way of doing things, even if I know a better way. I'll only push for the better way if I, or someone else, is willing to refactor the whole codebase. Last thing I want is to work on a codebase with N different ways to solve the same problem. That decreases productivity too much.
- jacquesm 3y agoThat makes sense. The problem is that it can be quite hard on large codebases to find such instances if they aren't routed through some library to avoid code duplication.