4 ms·
This is what I implemented prior to my team growing beyond 1 person. If linting passes, it’s valid style. If you think the style is problematic, that’s an issue
by Waterluvian 3y ago
This is what I implemented prior to my team growing beyond 1 person. If linting passes, it’s valid style. If you think the style is problematic, that’s an issue with the linting and formatting and not the PR. In practice this hasn’t been a problem. We’ve made 2 or 3 linting PRs over the years.
- mtsr 3y agoIt’s why opinionated tools like rustfmt are so good. They set and enforce a standard which is good enough that even perfectionists don’t feel like arguing them ad nauseam.
- Waterluvian 3y agoYeah! Any one opinion may not be the best for any one person, but everyone being consistent is the best for everyone.
- hereonout2 3y agoIntroducing linting in the test stage (flake8 with python) solves so many problems. By completely removing any personal preferences and disagreements on style, the whole team just gets to hate on and berate an inanimate tool instead. We all just seem to equally dislike flake8 and move on with our lives.