3 ms·
Yeah that's a constant struggle, developers thinking less and / or clever code is better code; it's self-gratification, and it should be stopped during code rev
by Cthulhu_ 3y ago
Yeah that's a constant struggle, developers thinking less and / or clever code is better code; it's self-gratification, and it should be stopped during code review. To them I'd say I'm sorry a series of simple if- statements doesn't challenge you intellectually, but the correctness of these checks are more important than your ego.
Of course, there's also a gap in unit tests if they can change an important check without a test failing.
- Ensorceled 3y agoIt was found during code review AND it revealed a gap in our unit tests. So, 50% success, I guess. Belt and suspenders.