4 ms·
These are real problems but not insurmountable. I think the author does an excellent job of laying out the problem and has pretty decent solutions in mind. I c
by mvdtnz 3y ago
These are real problems but not insurmountable. I think the author does an excellent job of laying out the problem and has pretty decent solutions in mind.
I caution strongly against the proposed solution to fail CI if zombie flags are detected. CI should ONLY fail if there are changes in the branch that cause the failure. Detecting zombie flags (eg, this branch contains a flag which has been turned on and untouched for 90 days) is setting a CI time bomb. Find another way to alert developers of the zombie instead of failing good code at CI time.
- travisjungroth 3y agoThe CI time bomb is the point. Other strategies are proven ineffective. It makes sense to either say: 1. The CI failures aren’t worth it. I accept the zombie flags. 2. Here’s a specific solution that will lead to zombie flags being removed and at a lower cost. Gesturing to “find another way” doesn’t solve it.
- sjducb 3y agoThe CI time bomb makes developers lives worse. You’re trying to get a new feature released, and some feature that everyone has forgotten about breaks the build and stops you from getting your feature out now. If the stakeholders won’t allocate time in the roadmap to remove old feature flags then you shouldn’t use feature flags.
- travisjungroth 3y agoGood point. Don't do feature flags is the third option.