5 ms·
Good suggestion! Actually the "ef" is not epsilon. It is a parameter of the HNSW index: https://github.com/nmslib/hnswlib/blob/master/ALGO_PARAMS.md#search-para
by yhmo 3y ago
Good suggestion!
Actually the "ef" is not epsilon. It is a parameter of the HNSW index: https://github.com/nmslib/hnswlib/blob/master/ALGO_PARAMS.md#search-parameters https://github.com/nmslib/hnswlib/blob/master/ALGO_PARAMS.md...
- marginalia_nu 3y agoYeah it wasn't referenced or mentioned anywhere in the article so I had to guess what it was :-/ ... which I guess supports my point. ef being "epsilon factor" was the least nonsensical thing I could come up with since it looked analogous to how you do like abs(a-b)<epsilon in floating point comparisons.
- yhmo 3y agoHm... adding links in code comment might be better.
- marginalia_nu 3y agoProbably a comment above the function explaining the incoming parameters, with a link to the specs if necessary, and then comments in the text and better variable names. I think in this scenario when the primary audience of the code isn't an interpreter, but people who don't understand HNSWs, and who will probably only glance over the code once or twice, you really can't lay on the verbosity heavily enough.