3 ms·
One of the most valuable feedback comments you can leave on a review is "hey I found this part confusing, can you add a comment?". I think sometimes people are
by recursivecaveat 3y ago
One of the most valuable feedback comments you can leave on a review is "hey I found this part confusing, can you add a comment?". I think sometimes people are afraid to admit something like that, but obviously if you're confused by it now, in-context, it will not be easier to understand in 16 months. In general you don't have to provide super clever bug catches, often a second set of eyes is all that's needed. Its surprisingly easy to leave really stupid stuff in your diffs, because you gloss over them, thinking you remember exactly what's in there. As long as you don't make any comments about style, or make a ton of work for them, people are usually very receptive. People enjoy shipping things that are quality, so if you give them an excuse they don't mind adding some comments or trying to merge 2 samey segments.