3 ms·
To be honest, rather than taking it out on a 18-year-old messing around for bragging rights, you really should have ripped a new one into the Rails people. They
by toyg 15y ago
To be honest, rather than taking it out on a 18-year-old messing around for bragging rights, you really should have ripped a new one into the Rails people. They knew of this problem (two bug reports were filed and closed) and completely dropped the ball. Now, this kid was noisy but harmless, and it did report the bug; someone else might have found the same hole (or read the same bugs) and exploited it silently for weeks.
This was really the worst option: you've taught a kid to keep his mouth shut next time he finds a hole. It will be much safer for him to sell it on the black market for a quick buck.
- rsynnott 15y agoIt's poor design in Rails, but not a security hole as such. The security hole was on GitHub's side.
- toyg 15y agoI'm no Rails expert, but I tend to like the OpenBSD philosophy: if you ship with default options that are known to be insecure, you have a security bug. I know security is always a trade-off, but when your largest and most famous testimonials, with all their mad skillz and street cred, still manage to get it so spectacularly wrong, it's clear that the core engine is as guilty as any other component.
- marshray 15y agoI like the part where the Rails developer says: The user has a flag to secure by default, I personally think that is enough. https://github.com/rails/rails/issues/5228#issuecomment-4300062 https://github.com/rails/rails/issues/5228#issuecomment-4300... In other words, Rails actually does have a flag to make the mass assignment feature secure by default. But this flag defaults to 'false'. https://github.com/rails/rails/pull/4062/files#diff-1 https://github.com/rails/rails/pull/4062/files#diff-1
- jasonlotito 15y agoThat's what PHP programmers were saying for years regarding magic_quotes (which didn't actually make things less secure). That this is apparently the default behaviour of Rails... yeah, it's a security issue.