3 ms·
Interesting. That doesn't seem like a complete clear cut case of it though, more the git-fu of the repo maintainer there might not be all that great. :( Sayin
by justinclift 3y ago
Interesting. That doesn't seem like a complete clear cut case of it though, more the git-fu of the repo maintainer there might not be all that great. :(
Saying that from looking at your PR:
https://github.com/duosecurity/duo_universal_php/pull/7 https://github.com/duosecurity/duo_universal_php/pull/7
Then looking at the commit which eventually got into their repo:
https://github.com/duosecurity/duo_universal_php/commit/c69e1382a94ace25ba41796962e1e9d2295ab568 https://github.com/duosecurity/duo_universal_php/commit/c69e...
Even though they fucked up the author name on the commit itself, they at least attempted to credit you in the commit title:
Merge PR 7 from theodorejb; Add missing type declarations and fix incorrect PHPDoc types
While that's not fantastic as it screws up proper attribution with pretty much every automated git tool... it doesn't seem like a case of them trying to claim credit for someone else's work.
That's just my impression anyway. Could be wrong. :D