3 ms·
In this particular case, we're talking some tricky code around array handling in the JS implementation of a major browser. It's pretty much the archetypical loc
by pdpi 3y ago
In this particular case, we're talking some tricky code around array handling in the JS implementation of a major browser. It's pretty much the archetypical location for a VM escape bug. That's most definitely not something you want to be cavalier about.
In general, the large, sprawling diffs we're talking about here, the sort that actually justify commits of this size, are almost always going to also be the sort that justify more closer scrutiny at review time.
- pizlonator 3y agoI doubt that a thorough review is going to find security bugs in a change like this. Good tests, a great fuzzer, and a highly motivated security research community - that’s how you find the great security bugs!