4 ms·
What is a forge in this context? Is that a name for a code repository website? I'm unfamiliar. Regardless, I think that's just a function of your team and your
by SCdF 3y ago
What is a forge in this context? Is that a name for a code repository website? I'm unfamiliar.
Regardless, I think that's just a function of your team and your dynamics that you've built up.
On the current team I'm on we for example don't require this (at least on GitHub its configurable), there is an understanding of nits, how to declare them and what that means, as well as an understanding of using request changes vs approve and so on. We've built this up by having discussions about what the purpose of reviews are (eg making sure your code is understandable by someone other than you), having a common understanding that perfect should never get in the way of good, etc.
We regularly have retrospectives where, if we were having issues with really bad pedantry, I would hope it could be brought up.
- 000ooo000 3y agoYep you got it. Forge, aka GitHub, GitLab, Bitbucket, etc
- snovv_crash 3y agoSourceForge being the prime example.
- 000ooo000 3y agoYou're 100% right regarding the team and its dynamics. I came from (and led) a team that had strict PR, but the difference is that we had well-established 'rules of engagement' so to speak, and just being decent people meant tone was never a factor. Unfortunately the product was given the 'tools down' order. It's.. quite different where I am now. Change requests for untouched/irrelevant code, tone problems, etc. I'd be inclined to try and 'raise the tide' but I'm just trying to leave instead for many other reasons.