3 ms·
> I currently work with the worst pedant I've encountered in my career to date, and I can empathise with wanting to leave the industry. I have one of these too
by Maxion 3y ago
> I currently work with the worst pedant I've encountered in my career to date, and I can empathise with wanting to leave the industry.
I have one of these too, one of my PRs received a comment on the third round of review about correcting a minor typo in a comment that was made years ago by someone else.
- gwright 3y agoFWIW, we started using https://conventionalcomments.org https://conventionalcomments.org a while back and found it to be a useful tool for making it easy to communicate what is an issue that needs to be fixed, a suggestion to consider, or a nitpick to optionally ignore. It is still just a tool and does require the team to buy-in and utilize it, but we've found it helpful.
- jrd259 3y agoIf the comment was in code you touched, this seems right. Typos affect searchabilty. If the typo was outside (but close to) the block you modified you shouldn't be required, and the team ought to have rules of engagement to state this.