3 ms·
How would code review work if everyone is committing and pushing? The article must mean tiny, short-lived branches
by goodoldneon 3y ago
How would code review work if everyone is committing and pushing? The article must mean tiny, short-lived branches
- kdmccormick 3y ago"Pair programming", maybe? Anyway, agreed. Particularly, I wonder how any significant refactoring is approached.
- jdlshore 3y agoRefactoring is easier with short-lived (minutes to a few hours) branches, because refactoring causes branches to diverge over time. Significant refactoring, done correctly, is a series of small refactorings, and they can be integrated every 30-60 min to minimize impact of changes.
- claytongulick 3y agoWith trunk based, code review happens as a sort of forcing function every time you do a pull and merge it in. You see what everyone has done and how it affects you before you can push. (I'm not advocating for this, but I've worked in this style and it has pros and cons).