3 ms·

Man, I'm afraid to get banned by opening a GitHub issue but the usb driver looks bad. AMEI themselves wrote a clean Windows interfacing portion of the driver.

Man, I'm afraid to get banned by opening a GitHub issue but the usb driver looks bad. AMEI themselves wrote a clean Windows interfacing portion of the driver. But they copy and pasted a MIDI driver meant for Arduinos for message parsing The code formatting is awful. you can't even follow nesting of if statements properly in some places https://github.com/microsoft/MIDI/blob/main/src/usb-driver/USB-UMPDriver/USB-UMPDriver/midi_cpp2/src/bytestreamToUMP.cpp#L175 https://github.com/microsoft/MIDI/blob/main/src/usb-driver/U... https://github.com/microsoft/MIDI/blob/main/src/usb-driver/USB-UMPDriver/USB-UMPDriver/midi_cpp2/src/bytestreamToUMP.cpp#L217 https://github.com/microsoft/MIDI/blob/main/src/usb-driver/U... https://github.com/microsoft/MIDI/blob/main/src/usb-driver/USB-UMPDriver/USB-UMPDriver/midi_cpp2/src/midiCIProcessor.cpp#L169 https://github.com/microsoft/MIDI/blob/main/src/usb-driver/U... https://github.com/microsoft/MIDI/blob/main/src/usb-driver/USB-UMPDriver/USB-UMPDriver/midi_cpp2/src/umpProcessor.cpp#L169 https://github.com/microsoft/MIDI/blob/main/src/usb-driver/U... Not something I ever want to see in a OS Vendor endorsed and probably soon distributed by default USB Driver lol

skissane 3y ago
> Man, I'm afraid to get banned by opening a GitHub issue but the usb driver looks bad. I think the reason why you might get banned is because your tone comes across as harsh and non-constructive. If instead of saying "The code formatting is awful", you said "I noticed the code formatting is a bit inconsistent and I'm not sure what (if any) code style it is following. Is there any way I can help improve this? Do you have a standard code formatting you follow, or any tools you've used to enforce code formatting? I've used X in the past, and I could contribute a PR to set you up with that, if that's something you are interested in" – nobody is going to ban you for putting it that way

skissane 3y ago

> Man, I'm afraid to get banned by opening a GitHub issue but the usb driver looks bad. I think the reason why you might get banned is because your tone comes across as harsh and non-constructive. If instead of saying "The code formatting is awful", you said "I noticed the code formatting is a bit inconsistent and I'm not sure what (if any) code style it is following. Is there any way I can help improve this? Do you have a standard code formatting you follow, or any tools you've used to enforce code formatting? I've used X in the past, and I could contribute a PR to set you up with that, if that's something you are interested in" – nobody is going to ban you for putting it that way