5 ms·

The quality of the code is terrible. They don't follow the objective-c naming guidelines, calling -dealloc directly, ... Please be aware of that.

3pt14159 15y ago
It is this type of attitude that stops other people from doing what they have done. Sometimes bad code is fine when you are prototyping something or getting something to just work. Sometimes people have knowledge gaps. Put your code up or shut up.
- 0x0 15y ago
  Obviously I can't speak for the original poster's intentions, but I figured it was just meant as a helpful reminder that parts of the code shouldn't be considered "best practise". It's great that they post code - it's just that newcomers might look at it, think "oh hey this might look like an OK way to do XYZ" - and then be surprised later when new iOS versions or whatever break because of shortcuts taken earlier. A gentle reminder that "this is not necessarily the proper way to do it" is appropriate in this context, I think. (I'm sure issues like these are common for many studios' games)
jamesu 15y ago
Coming from a game development background, i've seen far worse.
startupcto 15y ago
Let's see some of your code on Github before you ......
LinaLauneBaer 15y ago
My comment was not meant to be insulting or anything like that. I just tried to be direct - thats all. The linked website says: "This allows aspiring game developers to learn and build their own games from the code." I had a look at the source code and what I found were mistakes that are made by absolute beginners of Objective-C. I am not talking about things like spaghetti code or bad variable names. I am talking about real WTFs here. Everyone can put up code on Github but then you have to live with the fact that people are pointing out flaws - especially if you encourage other people to learn from the code you put up.
- sequoia 15y ago
  It would be much more positive and educational (and therefor more useful) if you pointed out some specific errors and their fixes, so people could learn something. What you're doing here is fair warning to people working off this code, but w/o adding some useful info it comes of as mere trash talking.
  - LinaLauneBaer 15y ago
    I have given two examples in my original post let me point them out again: - the code does not comply to naming conventions – the solution in obvious: follow the naming guidelines. - the code calls -dealloc directly – the solution: don't do this. Never ever. If someone wants to know more details feel free to say so.

3pt14159 15y ago

It is this type of attitude that stops other people from doing what they have done. Sometimes bad code is fine when you are prototyping something or getting something to just work. Sometimes people have knowledge gaps. Put your code up or shut up.

0x0 15y ago
Obviously I can't speak for the original poster's intentions, but I figured it was just meant as a helpful reminder that parts of the code shouldn't be considered "best practise". It's great that they post code - it's just that newcomers might look at it, think "oh hey this might look like an OK way to do XYZ" - and then be surprised later when new iOS versions or whatever break because of shortcuts taken earlier. A gentle reminder that "this is not necessarily the proper way to do it" is appropriate in this context, I think. (I'm sure issues like these are common for many studios' games)

jamesu 15y ago

Coming from a game development background, i've seen far worse.

startupcto 15y ago

Let's see some of your code on Github before you ......

LinaLauneBaer 15y ago

My comment was not meant to be insulting or anything like that. I just tried to be direct - thats all. The linked website says: "This allows aspiring game developers to learn and build their own games from the code." I had a look at the source code and what I found were mistakes that are made by absolute beginners of Objective-C. I am not talking about things like spaghetti code or bad variable names. I am talking about real WTFs here. Everyone can put up code on Github but then you have to live with the fact that people are pointing out flaws - especially if you encourage other people to learn from the code you put up.

sequoia 15y ago
It would be much more positive and educational (and therefor more useful) if you pointed out some specific errors and their fixes, so people could learn something. What you're doing here is fair warning to people working off this code, but w/o adding some useful info it comes of as mere trash talking.
- LinaLauneBaer 15y ago
  I have given two examples in my original post let me point them out again: - the code does not comply to naming conventions – the solution in obvious: follow the naming guidelines. - the code calls -dealloc directly – the solution: don't do this. Never ever. If someone wants to know more details feel free to say so.