4 ms·

Feedback as an experienced Symfony developer: I am not sure if this is the first time you work with Symfony but before going to add anything new you should rea

by naiv 3y ago

Feedback as an experienced Symfony developer: I am not sure if this is the first time you work with Symfony but before going to add anything new you should really improve the code quality, add static analysers like Phpstan and Psalm, bring them to level 9 and 1, restructure your src dir, create reasonable entities, improve the unit tests. Also, your license needs to be reviewed by legal and your it insurance company (I hope you have one as you will need one for sure working in the billing area), it is completely flawed. I think you just copied it from somewhere and added your information.

that_guy_iain 3y ago
> I am not sure if this is the first time you work with Symfony but before going to add anything new you should really improve the code quality, add static analysers like Phpstan and Psalm, bring them to level 9 and 1, restructure your src dir, create reasonable entities, improve the unit tests. Code quality wise it has a scrutinizer score of 9.85 out of 10. Sure code quality could be improved like all other applications in the world, but let's not act like it's low or poor quality. If you have specific feedback I would like to hear it but "improve code quality" is one of the biggest things people say when they have no concrete improvements or can even explain why their changes improves code quality. It's normally "I would do it this way". > improve the unit tests. I made the decision since it's MVP to focus on functional tests since it gives a wider range and could be done quicker. For things where the logic is important I wrote unit tests which is why there aren't so many Unit tests but 20 minutes worth of functional tests. > Also, your license needs to be reviewed by legal and your it insurance company (I hope you have one as you will need one for sure working in the billing area), it is completely flawed. I think you just copied it from somewhere and added your information. It's literally a template given by MariaDB Corporation Ab which it states and even says the license is copyrighted to them. It's used by quite a few companies. Such as Sentry and CoackroachDB. So, yes. I copied it and edited the parts it said to edit. Just like I would a standard open-source license. And considering it's used by multiple multi-million dollar companies, I am going to go with it passes the legal test of actual lawyers.

by naiv 3y ago

that_guy_iain 3y ago

> I am not sure if this is the first time you work with Symfony but before going to add anything new you should really improve the code quality, add static analysers like Phpstan and Psalm, bring them to level 9 and 1, restructure your src dir, create reasonable entities, improve the unit tests. Code quality wise it has a scrutinizer score of 9.85 out of 10. Sure code quality could be improved like all other applications in the world, but let's not act like it's low or poor quality. If you have specific feedback I would like to hear it but "improve code quality" is one of the biggest things people say when they have no concrete improvements or can even explain why their changes improves code quality. It's normally "I would do it this way". > improve the unit tests. I made the decision since it's MVP to focus on functional tests since it gives a wider range and could be done quicker. For things where the logic is important I wrote unit tests which is why there aren't so many Unit tests but 20 minutes worth of functional tests. > Also, your license needs to be reviewed by legal and your it insurance company (I hope you have one as you will need one for sure working in the billing area), it is completely flawed. I think you just copied it from somewhere and added your information. It's literally a template given by MariaDB Corporation Ab which it states and even says the license is copyrighted to them. It's used by quite a few companies. Such as Sentry and CoackroachDB. So, yes. I copied it and edited the parts it said to edit. Just like I would a standard open-source license. And considering it's used by multiple multi-million dollar companies, I am going to go with it passes the legal test of actual lawyers.