4 ms·
I'm all in favor of junior developer reviews and approvals. I completely agree that if they can't understand the code, it's frequently a problem with the code.
by hirundo 3y ago
I'm all in favor of junior developer reviews and approvals. I completely agree that if they can't understand the code, it's frequently a problem with the code. I'm against rubber stamps, where there's no evidence that they've engaged with it. Unfortunately that's the rule rather than the exception in my current environment. If e.g. a developer hasn't made a comment in dozens of reviews, and just returns an approval in a few minutes, junior or not it's a problem. My code isn't that good. Here, it's an epidemic among the juniors.
- scastiel 3y agoOn this point I agree with you. And in my experience, it happens as often with seniors as with juniors. The famous “LGTM” on a 1000-line PR ;)