3 ms·
It would only be shifting the blame if they weren’t going to work around the problem in Firefox itself. The C++ compiler may or may not implement stack probing
by db48x 3y ago
It would only be shifting the blame if they weren’t going to work around the problem in Firefox itself.
The C++ compiler may or may not implement stack probing correctly, but this bug is in the Javascript JIT compiler. The fix is to make the JIT compiler update the stack pointer register each time through the loop so that if a page fault happens the kernel won’t see a huge amount of stack get allocated all in one go. Instead it’ll see several page faults each asking for a smaller amount which it is happy to grant.
See https://phabricator.services.mozilla.com/rMOZILLACENTRAL304d01f5488b384023a1c647e8c5c2f5cee32a5b https://phabricator.services.mozilla.com/rMOZILLACENTRAL304d...
- deleted 3y ago[deleted]