4 ms·
For public open source projects there are lots of reasons to review and send an acked-by/reviewed-by line, at least some of which I think would carry across int
by pm215 15y ago
For public open source projects there are lots of reasons to review and send an acked-by/reviewed-by line, at least some of which I think would carry across into a company-internal equivalent:
* if you review other peoples' patches they're more likely to review yours, which means your code is more likely to get committed.
* pointing out a problem and saying 'fix this' or 'have you tested X?' is cheap for you because the patch rework and retesting effort is on the other person. If you don't review and let something dubious through in a bit of code you care about and then have to track down and submit a fix later that's much more effort.
* it builds your reputation with other developers when you spot problems or suggest sensible design improvements. In open source projects this means internet fame. In the company-internal context it probably means better feedback at your next performance review :-)