3 ms·
I would be highly skeptical of any engineer making grand generalizations about a product without actually working with it for a fairly long time. It’s SO easy
by duxup 3y ago
I would be highly skeptical of any engineer making grand generalizations about a product without actually working with it for a fairly long time. It’s SO easy to belittle code without really knowing the whys and history.
I get that is what their job is when doing due diligence… but I think it’s also a little bit impossible.
I know I have thought of some code as poor, rewritten it “better” only to find my code is insufficient and quickly evolving into the same code I thought was bad…. for all the same reasons that influenced the original code… and thinking much more of the old / bad—- proven code.
- touisteur 3y agoThere are still some other metrics and heuristics you can use, such as number (and coverage) of tests, overall code metrics, number of compiler warnings, that tell you a little bit about the care put in maintaining the codebase. You can still have quality codebases without those (do I know...) but then you'd have to look at critical business metrics (uptime, latency, satisfaction surveys) or the number of tickets (even there, beware) or the overall 'cost and duration to deliver a fix or a new feature'. As for architecture, it's harder to find generic metrics and guidelines for 'quality'... I won't dive in there but external evaluation by people with no or little idea of the actual domain is not very interesting. Moreover people tend to be biased by either 'we at x have done it like this, and we're successful, so...' and 'we at x have built shit' and it's very hard to get in a sort of clean-slate mindset.
- duxup 3y agoThere certainly are things they can evaluate. Just that I think big picture wise I would be hard to draw too much of a conclusion from the testable metrics. Personally I’d want to test the app itself and if it works / customers are happy, I might worry a lot less about metrics and other decisions.