3 ms·
I've always been an advocate of people using the tools that work best for them. But sometimes, there's better tools out there than $EDITOR, especially when wor
by EdwardDiego 3y ago
I've always been an advocate of people using the tools that work best for them.
But sometimes, there's better tools out there than $EDITOR, especially when working in large codebases.
Like a recent PR where 4 out of 5 usages of a renamed variable also got renamed, but the last one didn't, and was in an area not covered by tests and it made it to main. (And yep, how it made it past review is a question I'll be asking...)
The dev had switched from VS Code to Neovim recently and I'm reasonably certain that's related.
I'm very comfortable riding motorcycles, but for taking my kids to school, I tend to use a car.
Horses for courses.
- codethief 3y ago> (And yep, how it made it past review is a question I'll be asking...) Given that refactoring support in VSCode is not exactly great, either, and that even Jetbrains products have countless bugs in their "Rename" feature, I'd rather ask: How did the change make it past your merge request pipelines?
- EdwardDiego 3y ago> an area not covered by tests Also, Django magic makes it very hard for tooling to actually know if something exists or not.
- WirelessGigabit 3y agoCheck out the parent of the PR, rename in VS Code and see if it catches it.