4 ms·
If it took you a day to write a branch, do you really want to sit quietly watching me read and think for an hour? Anyway, everything I can’t understand without
by erik_seaberg 3y ago
If it took you a day to write a branch, do you really want to sit quietly watching me read and think for an hour? Anyway, everything I can’t understand without asking you needs to get written down for the on-call eng next year.
- nightpool 3y ago> If it took you a day to write a branch, do you really want to sit quietly watching me read and think for an hour? Yes, absolutely, if that hour is going to be productive and collaborative in coming up with ways to make the code better (which every in-person code review I've been in has been) > everything I can’t understand without asking you needs to get written down for the on-call eng next year No, everything that you can't understand without asking me should be fixed by both of us so that it can be understood by everybody. Approving hard to understand code just because it's been "documented" hurts the entire codebase.