4 ms·
I only looked over your code for a minute but found some stuff I would comment on in a code review. Comment for a method says "null safe" - why not use an anno
by pragmatick 3y ago
I only looked over your code for a minute but found some stuff I would comment on in a code review.
Comment for a method says "null safe" - why not use an annotation?
A package called "util" is a code smell for me.
UrlUtils only provides two methods for URL encoding so why not name it appropriately?
- Tokumei-no-hito 3y agoI’ve always heard about the “util” package code smell but usually in complex contexts that are hard to discuss. How would you refactor this to avoid a util package or a UrlUtils class?