25 ms·
Looks fine to me. Syntax is the run-of-the-mill post-Java style currently favored, as exemplified by e.g. Haskell or Rust. Not a fan personally, but this is wha
by TeMPOraL 3y ago
Looks fine to me. Syntax is the run-of-the-mill post-Java style currently favored, as exemplified by e.g. Haskell or Rust. Not a fan personally, but this is what is popular now, so that's what we have to live with ¯\_(ツ)_/¯.
Style-wise, looks fine. Code split up into functions where it makes sense, inlined where it doesn't. I've seen worse - for example, code that takes the equivalent of that, and splits it into 100 functions across 10+ files.
- wiseowise 3y ago> I've seen worse - for example, code that takes the equivalent of that, and splits it into 100 functions across 10+ files. This so many times. Will never understand why people are so afraid of multi thousand lines of properly structured code but will happily giggle when the same structure is split across 10-20 files. And no, it’s not for reuse sake.
- voakbasda 3y agoMany thousand lines of structured code that does not get broken into logical modules ends up an unnavigable and unmaintainable mess. I would not hesitate to split up such code. Encapsulation and modularity are good engineering practices. Personally, I will not contribute to any project that opposes such things
- wiseowise 3y ago> Many thousand lines of structured code that does not get broken into logical modules ends up an unnavigable and unmaintainable mess. Where did I say anything about that?