3 ms·
You are both misunderstanding the post. He’s not saying to alter any of the feature flags used for the test, but simply to record which were used during the te
by linuxdude314 3y ago
You are both misunderstanding the post.
He’s not saying to alter any of the feature flags used for the test, but simply to record which were used during the test.
Simply logging doesn’t introduce any of the issues you are describing.
- jsnell 3y agoHuh? This is what yojo@ wrote: > I think best practice here is to hardcode all feature flags to off in the integration test suite That's pretty clearly about forcing the flags to be off, i.e. altering them, and not about logging their values.
- yojo 3y agoAgreed, I am advocating for deterministic behavior for all feature flags in the test suite. If you’re testing a new feature, you should have explicit tests for the enabled state (along with existing tests for the disabled state). If you have bugs propagating up the stack from flags changing in low-level dependencies, the change to the dependency is probably not properly tested. Alternatively, if the feature flag gates a change to the interface of the dependency, you should have explicit integration tests covering the systems on both sides of the change.