4 ms·

Unlike lemmy, this has the advantage of links being links, so e.g. middle/ctrl. clicking works for everything, while in lemmy some (e.g. "X comments") are JS on

Unlike lemmy, this has the advantage of links being links, so e.g. middle/ctrl. clicking works for everything, while in lemmy some (e.g. "X comments") are JS only.

capableweb 3y ago
That's such a surface issue though and can be solved quickly. Much more interesting to compare the architecture and other things that can't be fixed by one day in some hours at max.
- MrThoughtful 3y ago
  I don't know the specific circumstances here. But making a link js-only is often a sign that the developers are not aware how much of a problem complexity is.
  - capableweb 3y ago
    Or, instead of using Link from whatever routing library they are using, they happen to use Button, or whatever. It can be a really simple issue as well as some underlying reason. But as a first response, I think it'll chalk it up to "ops, we missed that" rather than "we like links that don't work like links", especially if the issue hasn't been reported yet.
elaus 3y ago
Where do you find the "X comments" links that are JS-only? Just visiting the home page of lemmy.ml, all comment links are actual links that can be opened in a new tab or copy-pasted (e.g. https://lemmy.ml/post/1186587?scrollToComments=true https://lemmy.ml/post/1186587?scrollToComments=true)
- Semaphor 3y ago
  Nowhere, now :( I swear it didn’t work for me when I posted this, but now it works, and I have absolutely no idea what changed. I even checked in git if there was some recent change, there wasn’t. I’m flabbergasted.
  - Semaphor 3y ago
    Found it. It actually doesn’t work at all: https://imgur.com/a/xuUfT4Q https://imgur.com/a/xuUfT4Q The first image is the button, which switches the cursor to one pretending to be a link, but only the second outline is actually clickable.
alpaca128 3y ago
Middle click works just fine for me on multiple lemmy instances.
- Semaphor 3y ago
  On the "X comments" text? That’s a `button` in code.
  - alpaca128 3y ago
    Yes. Middle click works perfectly, just like on HN and old reddit etc.
    - Semaphor 3y ago
      Interesting, turns out chrome allows you to middle click on <button> when it wraps <a>. FF does not. > just like on HN and old reddit etc. Those use plain links
      - alpaca128 3y ago
        > turns out chrome allows you to middle click on <button> when it wraps <a>. FF does not. It works on Firefox, Safari and Brave/Chromium the exact same way for me, middle click always work. Not sure what you mean.
        Semaphor 3y ago
        I’m so confused. Now that’s the case. But I didn’t dream being unable to open those in a new tab. WTF could be going on? I even looked at the git repo, no recent relevant changes
        Semaphor 3y ago
        Found the issue. It actually doesn’t work at all: https://imgur.com/a/xuUfT4Q https://imgur.com/a/xuUfT4Q The first image is the button, which switches the cursor to one pretending to be a link, but only the second outline is actually clickable. I added a gif as demo, will also report this to lemmy.

Unlike lemmy, this has the advantage of links being links, so e.g. middle/ctrl. clicking works for everything, while in lemmy some (e.g. "X comments") are JS only.

capableweb 3y ago

That's such a surface issue though and can be solved quickly. Much more interesting to compare the architecture and other things that can't be fixed by one day in some hours at max.

MrThoughtful 3y ago
I don't know the specific circumstances here. But making a link js-only is often a sign that the developers are not aware how much of a problem complexity is.
- capableweb 3y ago
  Or, instead of using Link from whatever routing library they are using, they happen to use Button, or whatever. It can be a really simple issue as well as some underlying reason. But as a first response, I think it'll chalk it up to "ops, we missed that" rather than "we like links that don't work like links", especially if the issue hasn't been reported yet.

elaus 3y ago

Where do you find the "X comments" links that are JS-only? Just visiting the home page of lemmy.ml, all comment links are actual links that can be opened in a new tab or copy-pasted (e.g. https://lemmy.ml/post/1186587?scrollToComments=true https://lemmy.ml/post/1186587?scrollToComments=true)

Semaphor 3y ago
Nowhere, now :( I swear it didn’t work for me when I posted this, but now it works, and I have absolutely no idea what changed. I even checked in git if there was some recent change, there wasn’t. I’m flabbergasted.
- Semaphor 3y ago
  Found it. It actually doesn’t work at all: https://imgur.com/a/xuUfT4Q https://imgur.com/a/xuUfT4Q The first image is the button, which switches the cursor to one pretending to be a link, but only the second outline is actually clickable.

alpaca128 3y ago

Middle click works just fine for me on multiple lemmy instances.

Semaphor 3y ago
On the "X comments" text? That’s a `button` in code.
- alpaca128 3y ago
  Yes. Middle click works perfectly, just like on HN and old reddit etc.
  - Semaphor 3y ago
    Interesting, turns out chrome allows you to middle click on <button> when it wraps <a>. FF does not. > just like on HN and old reddit etc. Those use plain links
    - alpaca128 3y ago
      > turns out chrome allows you to middle click on <button> when it wraps <a>. FF does not. It works on Firefox, Safari and Brave/Chromium the exact same way for me, middle click always work. Not sure what you mean.
      - Semaphor 3y ago
        I’m so confused. Now that’s the case. But I didn’t dream being unable to open those in a new tab. WTF could be going on? I even looked at the git repo, no recent relevant changes
      - Semaphor 3y ago
        Found the issue. It actually doesn’t work at all: https://imgur.com/a/xuUfT4Q https://imgur.com/a/xuUfT4Q The first image is the button, which switches the cursor to one pretending to be a link, but only the second outline is actually clickable. I added a gif as demo, will also report this to lemmy.