4 ms·
https://github.com/ff4j/ff4j/blob/v1/ff4j-core/src/main/java/org/ff4j/strategy/time/ReleaseDateFlipStrategy.java#L100 https://github.com/ff4j/ff4j/blob/v1/ff4j-
by tantalor 3y ago
https://github.com/ff4j/ff4j/blob/v1/ff4j-core/src/main/java/org/ff4j/strategy/time/ReleaseDateFlipStrategy.java#L100 https://github.com/ff4j/ff4j/blob/v1/ff4j-core/src/main/java...
> The feature will be flipped after release date is reached.
Don't ever use this. This is a "time bomb". This is a very bad idea. It's basically like scheduling a time for your app to go down when you aren't paying attention.
You have to have a human in the loop. The right way to "schedule a release" is to have a human flip the flag at the appropriate time (preferably, ramp it up to 100% of users gradually) and then stay online for a little while to do an emergency ramp down if/when things go bad (that weren't caught by some automated system in the ramp up).
- furstenheim 3y agoUnless you have a legal requirement starting on January the 1st 00:00
- r4um 3y agoAgreed. Problem isn’t timed rollout but lack of automated rollback. If you don’t have one don’t do this. The automated rollback should look for acceptable error rates, latency etc.
- agilob 3y agoUh this class is even worse, SDF is not a thread safe date formatter, so it never should be `final static`. `releaseDate` and `new Date()` will be ignorant of summer/winter time changes. For such scheduling one should use Quartz https://www.quartz-scheduler.org/ https://www.quartz-scheduler.org/
- deleted 3y ago[deleted]