4 ms·
You genuinely review 5k LOC PRs? If I was doing a proper review of a PR that big and making sure you understand how everything works that would easily take mul
by ZephyrBlu 3y ago
You genuinely review 5k LOC PRs?
If I was doing a proper review of a PR that big and making sure you understand how everything works that would easily take multiple days and generate 10s-100s of comments.
In reality I would flat out refuse to review it. Even 1k is very large without being broken down.
The only time I see PRs that big at work are cleanups (E.g. deleting whole directories), automated linting changes across the whole codebase and large structural refactors (E.g. changing directory structure).
- opportune 3y agoAlmost every time I’ve reviewed a 1k+ LOC PR, even if it’s from a really experienced and good engineer, it has introduced a bug. Obviously I’m not gonna say it at work, but changes that big are too hard to properly review and consider all side effects and gotchas
- tstrimple 3y agoIt's also more difficult to bisect to find the actual bug. Small commits have a lot of advantages.