4 ms·
Two key points that helped my team through a rough patch were: - one of my co-workers setup CI automated formatting/style checks (i.e. PEP8, mypy, isort, etc.)
by somethoughts 3y ago
Two key points that helped my team through a rough patch were:
- one of my co-workers setup CI automated formatting/style checks (i.e. PEP8, mypy, isort, etc.)
- much more extensive guides on how to contribute good code with many generalized examples as well as do's/don'ts. When new nitpick comments come out in the PRs - the guides were updated to avoid future nitpick PR comments
After some initial pain - we really haven't had issues with PRs anymore whereas before it was pretty painful. That said we've been working together for quite a while now.
I think a lot of times the original author may have something in mind w.r.t. the codebase/architecture/formatting/schools of thought and expect the others will pick up those ideas naturally and they get frustrated when other team members don't.
The other team members being code commented to oblivion get frustrated with what seems obscure, snarky nitpicks.
By making stuff explicit upfront - people can self help/self correct/self edit before the PR is even generated.